CB-14076: (ios) Setting UIWebViewDelegate on CDVWebViewEngineProtocol doesn't work

[dpolivy]

Attempts to use CDVWebViewEngineProtocol::updateWithInfo to set a new UIWebViewDelegate were not working; instead of setting the passed in delegate, it was setting the CDVViewController instance as the delegate instead.

Platforms affected

cordova-ios

What does this PR do?

This commit fixes the CDVWebViewEngine class so that the proper delegate is ultimately passed in to the UIWebView when calling updateWithInfo.

What testing has been done on this change?

I used the code to create a new test app, to which I applied a test plugin which attempts to set the UIWebViewDelegate. I verified that I was able to successfully set the delegate, and receive the events from the UIWebView.

I also ran npm test and verified all tests passed.

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[codecov-io]

Codecov Report

Merging #365 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #365   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          14       14           
  Lines        1697     1697           
  Branches      286      286           
=======================================
  Hits         1086     1086           
  Misses        611      611

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634176b...d24fe18. Read the comment docs.

[shazron]

Thanks for the PR. Unfortunately this doesn't cover the case when the delegate is not set. Basically set it to the self.viewController like the existing code (in an else statement)

[shazron]

Sorry I take that back, it is already set to the default in pluginInitialize