Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-559 Fixing dynamic framework installation path #560

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

bhariharan
Copy link
Contributor

Platforms affected

  • cordova-ios 5.0.0

Motivation and Context

  • The newly added dynamic target in the CordovaLib project does not get embedded correctly in an app binary. Attempting to build an IPA file will throw a dylib not found error with Cordova.framework.
  • Details in this GitHub issue.

Description

  • Changes are simple and isolated.
  • Added the default base path that's required for a dynamic target.

Testing

  • Tested extensively with my own project.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #560 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc774e6...236c5fd. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #560 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          11       11           
  Lines        1822     1822           
=======================================
  Hits         1362     1362           
  Misses        460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc774e6...236c5fd. Read the comment docs.

@dpogue dpogue merged commit a559d52 into apache:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants