Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override id with ios-CFBundleIdentifier #566

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Override id with ios-CFBundleIdentifier #566

merged 1 commit into from
Mar 7, 2019

Conversation

malwatte
Copy link
Contributor

@malwatte malwatte commented Mar 7, 2019

Override id with ios-CFBundleIdentifier when both id and ios-CFBundleIdentifier are defined in config.xml

Platforms affected

iOS

Motivation and Context

When both id and ios-CFBundleIdentifier are defined in config.xml, Xcode project should be created with ios-CFBundleIdentifier as the bundle identifier. Else, bundle identifier should be the id.
#565

Description

Check both packageName(i.e. id) and ios-CFBundleIdentifier when creating the platform (Xcode project)

Testing

Tested these scenarios,

  1. config.xml with both id and ios-CFBundleIdentifier
  2. config.xml with id only
  3. config.xml with ios-CFBundleIdentifier only

Checklist

  • [X ] I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [ X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Override id with  ios-CFBundleIdentifier  when both id and ios-CFBundleIdentifier is set in config.xml
@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #566 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #566   +/-   ##
======================================
  Coverage    74.6%   74.6%           
======================================
  Files          11      11           
  Lines        1823    1823           
======================================
  Hits         1360    1360           
  Misses        463     463
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 70.46% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e5929...31c440c. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

It would be nice to have tests to verify this behaviour, but it looks like the whole Api.js create method is lacking in tests at the moment. 😞 A problem to be dealt with in a future PR.

@dpogue dpogue added this to the 5.0.1 milestone Mar 7, 2019
@dpogue dpogue merged commit 1d59304 into apache:master Mar 7, 2019
@engr-erum
Copy link

i m still getting same issue during app submission :
The Info.plist CFBundleIdentifier value 'org.apache.cordova.Cordova' of 'AppName.app/Frameworks/Cordova.framework' is already in use by another application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants