Changed viewWillDisappear to viewDidDisappear because frame not resized sometimes. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed corresponding JIRA issue: https://issues.apache.org/jira/browse/CB-4136 |
|
Is this still needed? The code has been moved out to a plugin: So this pull request can't be applied as is. @baryshev - can you close it and re-open at https://github.com/apache/cordova-plugins/tree/master/keyboard if needed? |
|
@baryshev Updated the issue since the code is now in the keyboard-plugin. But you can close this PR now since this code has been moved away from the core |
|
@baryshev Please close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If navigator.camera.getPicture called while virtual keyboad is shown - frame still have wrong size because viewWillDisappear remove observers before keyboard close. This commit fixed that bug.