Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build.json): spacing in error message and missing path in log #650

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

janpio
Copy link
Member

@janpio janpio commented Jul 18, 2019

Motivation and Context

An error message is missing a space in the error message, and the log is missing the path completely because it doesn't concat the string

closes #648

Description

Fix both issues.

Testing

none

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   74.24%   74.24%           
=======================================
  Files          11       11           
  Lines        1833     1833           
=======================================
  Hits         1361     1361           
  Misses        472      472
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/build.js 51.26% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b22730...ae70aa6. Read the comment docs.

@janpio janpio marked this pull request as ready for review July 18, 2019 17:01
@janpio janpio requested a review from erisu July 18, 2019 17:01
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Testing

$ cordova compile ios --device --buildConfig=buildTest.json
Reading build config file: /test/iosTestProject/buildTest.json
$ cordova compile ios --device --buildConfig=badFile.json
(node:10663) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
CordovaError: Promise rejected with non-error: 'Build config file does not exist: badFile.json'
    at /cordova/bin/cordova:29:15
    at processTicksAndRejections (internal/process/task_queues.js:85:5)

Unhandled promise rejections will need to be handled but is out-of-scope of this ticket/PR. This existed before these changes.

@brodybits
Copy link
Contributor

Unhandled promise rejections will need to be handled but is out-of-scope of this ticket/PR. This existed before these changes.

Is this observation tracked in an issue?

@janpio janpio merged commit 66eb418 into master Jul 19, 2019
@janpio janpio deleted the janpio-buildjson branch July 19, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to --buildConfig is not output in log although code indicates it should
4 participants