Fix, simplify and improve tests #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around jhnns/rewire#167 by using Jasmine's `spyOn` to stub global variables like `process` and `console`.
This has multiple benefits: - we don't register too many listeners on `cordova-common.events` - we silence all output from Api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a collection of fixes, simplifications and general improvements of the unit-test code in this repository.
I stumbled across the issues that were fixed here, during preparation of a PR that simplifies async tests, similar to apache/cordova-lib#619.
Description
For details, please see the individual commits