breaking: bump deployment-target to 11.0 #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
changed the title
erisu
force-pushed
the
breaking/bump-deployment-target
branch
from
3d5c978
to
3c3d864
Compare
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 11 11
Lines 1815 1815
=======================================
Hits 1348 1348
Misses 467 467
Continue to review full report at Codecov.
|
2 tasks
NiklasMerz
pushed a commit
to GEDYSIntraWare/cordova-ios
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The purpose of this PR is to bump the minimum deployment target to iOS 11+.
This PR prepares the repo with the requirements to resolve issues/problems that were introduced when dropping UIWebView for WKWebView.
One example is the strict CORS request guidelines the WKWebView enforces. CORS requests can not be made from the
file://. To resolve this, the minimum deployment target must be 11+ before the solution can be implemented in a later PR.Description
Bump the
IPHONEOS_DEPLOYMENT_TARGETto11.0Testing
npm tcordova platform addcordova build iosChecklist