Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Append startURL to the initial url loaded #973

Merged
merged 1 commit into from Aug 27, 2020

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Aug 23, 2020

When using a custom scheme (app in example), the initial url loaded is app://localhost

This PR makes the initial url loaded to append the startURL to the url, in example app://localhost/index.html

This makes possible to run the tests as they use <content src="cdvtests/index.html" />, so now the url loaded will be app://localhost/cdvtests/index.html instead of app://localhost.

@jcesarmobile jcesarmobile requested review from dpogue and erisu Aug 23, 2020
erisu
erisu approved these changes Aug 27, 2020
Copy link
Member

@erisu erisu left a comment

👍 LGTM

Tested locally both with and without paramedic.

Waiting for @dpogue to review and merge since he will be preparing the upcoming patch release.

dpogue
dpogue approved these changes Aug 27, 2020
Copy link
Member

@dpogue dpogue left a comment

Looks good to me

@dpogue dpogue merged commit fd08e6c into apache:master Aug 27, 2020
@jcesarmobile jcesarmobile deleted the fix-content-url branch Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants