Skip to content

fix: Append startURL to the initial url loaded#973

Merged
dpogue merged 1 commit into
apache:masterfrom
jcesarmobile:fix-content-url
Aug 27, 2020
Merged

fix: Append startURL to the initial url loaded#973
dpogue merged 1 commit into
apache:masterfrom
jcesarmobile:fix-content-url

Conversation

@jcesarmobile

Copy link
Copy Markdown
Member

When using a custom scheme (app in example), the initial url loaded is app://localhost

This PR makes the initial url loaded to append the startURL to the url, in example app://localhost/index.html

This makes possible to run the tests as they use <content src="cdvtests/index.html" />, so now the url loaded will be app://localhost/cdvtests/index.html instead of app://localhost.

@jcesarmobile
jcesarmobile requested review from dpogue and erisu August 23, 2020 23:03

@erisu erisu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Tested locally both with and without paramedic.

Waiting for @dpogue to review and merge since he will be preparing the upcoming patch release.

@dpogue dpogue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dpogue
dpogue merged commit fd08e6c into apache:master Aug 27, 2020
@jcesarmobile
jcesarmobile deleted the fix-content-url branch August 27, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants