Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to add a plugin from drive different from c: #135

Closed
wants to merge 1 commit into from
Closed

allow to add a plugin from drive different from c: #135

wants to merge 1 commit into from

Conversation

Athorcis
Copy link

This commit alllow to add plugin from a drive different from c: when using bash under Windows.
Therefore the following command now work:

cordova plugin add /d/home/cirkwi/mobile/plugins/cordova-plugin-assets

This commit alllow to add plugin from a drive different from c: when using bash under Windows.
Therefore this command now work: cordova plugin add /d/home/cirkwi/mobile/plugins/cordova-plugin-assets
@asfgit asfgit closed this in c6870a1 Dec 23, 2014
@agrieve
Copy link
Contributor

agrieve commented Dec 23, 2014

Thanks for the patch! Looks like in a couple of other files, we do:
./cordova/config.js: else if (uri.protocol && uri.protocol[1] ==':') return uri.href;
./cordova/lazy_load.js: isUri = uri.protocol && uri.protocol[1] != ':';

So, I've used that check instead of your PR to make the fix.
The relevant JIRA issue is https://issues.apache.org/jira/browse/CB-7610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants