CB-8123 Plugin references can target specific windows platforms. #155
Conversation
Adds support for `target`, `versions` and `arch` attributes on `<lib-file>` and `<framework>` elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms. Also adds support for `src` attribute as an alias for the `Include` attribute on the `<lib-file>` element (since `src` is documented, but `Include` is used by existing plugins). Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform). As part of this change, refactored `jsproj` to `jsprojManager` to reflect the fact that, with the windows platform, this class now manages multiple jsproj files. Note that I plan to rename some windows8 files and folders to windows, and jsproj.js to jsprojManager.js in a subsequent commit.
Renames `windows8` plugin platform folders in tests to `windows`. Renames `jsproj.js` to `jsprojManager.js`.
Renames `windows8.spec.js` to `windows.spec.js`.
|
Very cool Tim! |
| var frameworks = copyArray(valid_frameworks); | ||
|
|
||
| it('should write to correct project files when conditions are specified', function () { | ||
| var xpath = 'ProjectReference[@Include="' + dummyplugin + '\\src\\windows\\dummy1.vcxproj"][@Condition="\'$(Platform)\'==\'x64\'"]'; |
There was a problem hiding this comment.
First failing test in Travis.
|
You should use path.join( ) in your tests when creating paths so the tests will still pass on MacOS, or check the environment and skip running your tests altogether. |
|
The tests use path.join(), but jsproj uses hard-coded backslashes (which is reasonable, because normally it would only run on Windows). This problem is showing up now because previously this code wasn’t exercised by tests. I’m looking to see if it is feasible/reasonable to update jsproj to be platform agnostic, to the extent it needs to be for tests to pass. I’d prefer that to skipping the tests, so we get consistent coverage (the tests don’t build projects – just verify that files are modified as expected). |
|
yeah, whichever approach is easier. Ultimately the test in this case is invalid, but we don't want it appearing to break the build. |
Conflicts: cordova-lib/spec-plugman/platforms/windows8.spec.js
|
I'll close this PR, and open a new, cleaned up PR. |
Adds support for
target,versionsandarchattributes on<lib-file>and<framework>elements in the windows platform of plugin.xml. This allows plugin authors to target different references to different target platforms.Also adds support for
srcattribute as an alias for theIncludeattribute on the<lib-file>element (sincesrcis documented, butIncludeis used by existing plugins).Adds some tests to cover the new attributes. Updates existing plugin tests for windows8 platform to also test windows platform (left in windows8 tests to help verify backward compatibility with old windows8 platform).
As part of this change, refactored
jsprojtojsprojManagerto reflect the fact that, with the windows platform, this class now manages multiple jsproj files.