CB-11777: Restore plugins before preparing #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
force-pushed
the
prepare-plugins
branch
from
4ea9b2a
to
03c2833
Compare
Current coverage is 80.38% (diff: 100%)@@ master #487 diff @@
==========================================
Files 67 67
Lines 5183 5184 +1
Methods 835 835
Messages 0 0
Branches 1005 1005
==========================================
+ Hits 4166 4167 +1
Misses 1017 1017
Partials 0 0
|
|
Nice investigating @dpogue! Good point about the hook order changing. My gut says it should be fine. Would that be a considered a major change is the question. |
|
Guess this won't matter if we rip restore out of prepare! |
|
I'm thinking we move forward with this as I'm feeling hesitant removing restore from prepare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
cordova prepareto restore platforms and plugins, the platform has prepare called before the plugins are restored. This leads to the top-level config.xml data being copied into the platform at prepare time, and then plugin config being appended when they are later restored.In my case, this was causing the Crosswalk version defined in my top-level config.xml to be overwritten by an undefined version when the plugin was installed. A workaround is to run
cordova preparea second time.A better fix is probably to restore the platforms, restore the plugins, and then run prepare after everything has been restored.
All the existing tests pass, but this does change the order of operations around the prepare hooks, and I'm not certain if other projects/plugins have dependencies on that ordering.
/cc @vladimir-kotikov