Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-11976 - Add deprecated node version warning for 0.x #497

Closed
wants to merge 1 commit into from
Closed

CB-11976 - Add deprecated node version warning for 0.x #497

wants to merge 1 commit into from

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 7, 2016

Platforms affected

All

What does this PR do?

Prints out a warning on prepare that you are using a deprecated node version, if you are using any node version 0.x

What testing has been done on this change?

Tested locally.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.

@codecov-io
Copy link

codecov-io commented Oct 7, 2016

Current coverage is 80.41% (diff: 100%)

Merging #497 into master will increase coverage by 0.01%

@@             master       #497   diff @@
==========================================
  Files            67         67          
  Lines          5189       5192     +3   
  Methods         836        836          
  Messages          0          0          
  Branches       1005       1006     +1   
==========================================
+ Hits           4172       4175     +3   
  Misses         1017       1017          
  Partials          0          0          

Powered by Codecov. Last update 4ca3b4c...65181b5

@shazron
Copy link
Member Author

shazron commented Oct 8, 2016

Making a change so it is shown on every command, not just prepare

@shazron
Copy link
Member Author

shazron commented Oct 10, 2016

We have to print the warning out in the getPlatformAPI method, somewhere before this line:

var cached = cachedApis[platformRootDir];

@shazron
Copy link
Member Author

shazron commented Oct 10, 2016

Closing. Can't have an effective warn in here, moving to cordova-cli.

@shazron shazron closed this Oct 10, 2016
@shazron shazron deleted the CB-11976 branch October 10, 2016 07:48
@vladimir-kotikov
Copy link
Member

@shazron, we still have "node": ">=0.9.9" in package.json. Might want to update it, so the users will see a warning at install time

@shazron
Copy link
Member Author

shazron commented Oct 10, 2016

@vladimir-kotikov good idea, I'll update it to >=4.0.0 since engineStrict is not used anymore in npm@3 -- and we should remove engineStrict anyways. This PR has moved to apache/cordova-cli#262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants