Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12002 - Add getAllowIntents() to ConfigParser #502

Closed
wants to merge 1 commit into from

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 12, 2016

Platforms affected

None, but I'm adding this as preparation for an iOS feature.

What does this PR do?

Adds a convenience method to retrieve the list of <allow-intent> tags from config.xml, similar to the getAllowNavigations() and getAccesses() methods.

What testing has been done on this change?

Additions to the existing spec tests.

Checklist

  • Reported an issue in the JIRA database: CB-12002
  • Commit message follows the format
  • Added automated test coverage as appropriate for this change.

@shazron
Copy link
Member

shazron commented Oct 12, 2016

Let's try to get this in for the cordova-common release for cordova-ios 4.3.0 release

@codecov-io
Copy link

Current coverage is 80.40% (diff: 100%)

Merging #502 into master will not change coverage

@@             master       #502   diff @@
==========================================
  Files            67         67          
  Lines          5189       5189          
  Methods         836        836          
  Messages          0          0          
  Branches       1005       1005          
==========================================
  Hits           4172       4172          
  Misses         1017       1017          
  Partials          0          0          

Powered by Codecov. Last update c44db3d...84f6333

@asfgit asfgit closed this in 6a3c763 Oct 12, 2016
@dpogue dpogue deleted the get-intents branch December 20, 2017 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants