Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13057 : added deprecation warning for cordova platform save #585

Merged
merged 1 commit into from
Aug 2, 2017
Merged

CB-13057 : added deprecation warning for cordova platform save #585

merged 1 commit into from
Aug 2, 2017

Conversation

audreyso
Copy link
Contributor

@audreyso audreyso commented Aug 1, 2017

Platforms affected

What does this PR do?

Added deprecation warning for cordova platform save

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

stevengill
stevengill approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but lets wait to see if anyone has feedback on us removing this command in cordova@8 before we merge it in

@asfgit asfgit merged commit 5d9e333 into apache:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengill stevengill stevengill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@audreyso @stevengill @asfgit