Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13501 : added support for node 8 and cleaned up eslint #604

Merged
merged 1 commit into from
Oct 31, 2017
Merged

CB-13501 : added support for node 8 and cleaned up eslint #604

merged 1 commit into from
Oct 31, 2017

Conversation

audreyso
Copy link
Contributor

Platforms affected

What does this PR do?

Added support for node 8 and fixed eslint error

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

stevengill
stevengill approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audreyso audreyso merged commit 30414ce into apache:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengill stevengill stevengill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@audreyso @stevengill