CB-14033 Support symbolic dir links on Windows#621
Conversation
|
I think it would be best to test with Cordova CLI, would be ideal to test with plugin which may be affected by this change. I can take a better look tomorrow. |
dpogue
left a comment
There was a problem hiding this comment.
I haven't tested this, but the changes look good to me
|
@brodybits Since there is a test that specifically targets the changed code, I'm quite confident it's OK. |
|
@brodybits Did you test this on Windows yet? Or did I misunderstand your comment? 🤔 |
|
My apologies, no time for me to test it this week, probably not much time next week either. Considering that you tested it in spec and got an approval from someone else I don't think you should let me block it. I do think it would be good for you to try a version of cordova-cli that does use a version of cordova-lib with this change and verify that it does actually solve the problem at some point. |
This uses junctions whenever creating directory symlinks on Windows since that does not require any special privileges.
Platforms affected
Windows
What does this PR do?
This uses junctions whenever creating directory symlinks on Windows since that does not require any special privileges.
What testing has been done on this change?
Tests on AppVeyor CI
Checklist