restore.spec: Wait for prepare promise to resolve #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test in pkgJson-restore.spec did NOT wait for the promise returned by `prepare` to be resolved before continuing with other tasks. Especially on Windows this could lead to EBUSY failures during cleanup and in turn to failures during following tests.
raphinesse
force-pushed
the
fix-restore-spec
branch
from
c2a8545
to
15791f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test in pkgJson-restore.spec did NOT wait for the promise returned
by
prepareto be resolved before continuing with other tasks.Especially on Windows this could lead to EBUSY failures during cleanup
and in turn to failures during following tests.
Note: The order of
emptyPlatformList()andprepare()does not seem to matter. Thus I chose the variant that was used throughout all other tests.