Fix promise handling when removing multiple plugins #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promises were not properly waited on.
dpogue
approved these changes
Jul 24, 2018
raphinesse
added a commit
to raphinesse/cordova-lib
that referenced
this pull request
Jul 25, 2018
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - Wrap all tests in common describe to allow common setup/teardown - Use a fresh tmpDir for every test to avoid caching issues - Use fs-extra for setup/teardown - FIX Wait for promise - Properly set default timeout for the whole suite - Don't symlink into fixtures - Sane config file handling - Remove event listeners on teardown - Re-enable disabled test 005 that was fixed by apache#628 - Do not quote props when not needed - Do not pass array when we only have scalar - Nicer imports - Save test platforms/plugins as constants
brodybits
pushed a commit
to brodybits/cordova-lib
that referenced
this pull request
Aug 3, 2018
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - Wrap all tests in common describe to allow common setup/teardown - Use a fresh tmpDir for every test to avoid caching issues - Use fs-extra for setup/teardown - FIX Wait for promise - Properly set default timeout for the whole suite - Don't symlink into fixtures - Sane config file handling - Remove event listeners on teardown - Re-enable disabled test 005 that was fixed by apache#628 - Do not quote props when not needed - Do not pass array when we only have scalar - Nicer imports - Save test platforms/plugins as constants
raphinesse
added a commit
to raphinesse/cordova-lib
that referenced
this pull request
Aug 4, 2018
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - Wrap all tests in common describe to allow common setup/teardown - Use a fresh tmpDir for every test to avoid caching issues - Use fs-extra for setup/teardown - FIX Wait for promise - Properly set default timeout for the whole suite - Don't symlink into fixtures - Sane config file handling - Remove event listeners on teardown - Re-enable disabled test 005 that was fixed by apache#628 - Do not quote props when not needed - Do not pass array when we only have scalar - Nicer imports - Save test platforms/plugins as constants
raphinesse
added a commit
to raphinesse/cordova-lib
that referenced
this pull request
Aug 14, 2018
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - Wrap all tests in common describe to allow common setup/teardown - Use a fresh tmpDir for every test to avoid caching issues - Use fs-extra for setup/teardown - FIX Wait for promise - Properly set default timeout for the whole suite - Don't symlink into fixtures - Sane config file handling - Remove event listeners on teardown - Re-enable disabled test 005 that was fixed by apache#628 - Do not quote props when not needed - Do not pass array when we only have scalar - Nicer imports - Save test platforms/plugins as constants
Merged
raphinesse
added a commit
to raphinesse/cordova-lib
that referenced
this pull request
Aug 15, 2018
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - Wrap all tests in common describe to allow common setup/teardown - Use a fresh tmpDir for every test to avoid caching issues - Use fs-extra for setup/teardown - FIX Wait for promise - Properly set default timeout for the whole suite - Don't symlink into fixtures - Sane config file handling - Remove event listeners on teardown - Re-enable disabled test 005 that was fixed by apache#628 - Do not quote props when not needed - Do not pass array when we only have scalar - Nicer imports - Save test platforms/plugins as constants
raphinesse
added a commit
that referenced
this pull request
Aug 15, 2018
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - Wrap all tests in common describe to allow common setup/teardown - Use a fresh tmpDir for every test to avoid caching issues - Use fs-extra for setup/teardown - FIX Wait for promise - Properly set default timeout for the whole suite - Don't symlink into fixtures - Sane config file handling - Re-enable disabled test 005 that was fixed by #628 - Do not quote props when not needed - Do not pass array when we only have scalar - Nicer imports - Save test platforms/plugins as constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix promise handling when removing multiple plugins.
What testing has been done on this change?
Ran existing automated tests. Wrote regression test.
Checklist