CB-14243: change dash to underscore for save-exact key reference #631
Conversation
Thanks @amaldonado for the contribution, merged it since it definitely looks right to me. A couple points of feedback: I think it could have been done a little bit better, raised #632 with the suggestion. This behavior is evidently not covered by the unit test suite, marking this as a major TODO item in #632. P.S. If I would do |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Platforms affected
This affects how plugins are added for both Android and IOS.
What does this PR do?
This PR fixes CB-14243. Cordova-lib is ignoring save-exact b/c the wrong key name is being used to reference it in the options object that is propagated from cli.js.
What testing has been done on this change?
Unit tests have been run and are passing.
Checklist