New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14243: change dash to underscore for save-exact key reference #631

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
2 participants
@amaldonado

amaldonado commented Aug 1, 2018

Platforms affected

This affects how plugins are added for both Android and IOS.

What does this PR do?

This PR fixes CB-14243. Cordova-lib is ignoring save-exact b/c the wrong key name is being used to reference it in the options object that is propagated from cli.js.

What testing has been done on this change?

Unit tests have been run and are passing.

Checklist

Reported an issue in the JIRA database
Commit message follows the format: "CB-14243: {message}"
Unit Tests pass

@brodybits brodybits merged commit 987ce2b into apache:master Aug 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brodybits

This comment has been minimized.

Contributor

brodybits commented Aug 3, 2018

Thanks @amaldonado for the contribution, merged it since it definitely looks right to me. A couple points of feedback:

I think it could have been done a little bit better, raised #632 with the suggestion.

This behavior is evidently not covered by the unit test suite, marking this as a major TODO item in #632.

P.S. If I would do npm i apache/cordova-lib#master in local checkout of cordova-cli then use that version to add a plugin with --save-exact flag it does save the exact plugin version in package.json & config.xml.

@brodybits brodybits referenced this pull request Aug 3, 2018

Closed

Spec cleanup #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment