Cleanup pkgJson-restore.spec #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not drop any test cases. However, it fixes various bugs in the existing expectations and often asserts stronger expectations than the original tests. Changes include: - DRY code - Improve formatting - Reduce excessive comments - Simplify platform list generation - More meaningful usage of describe blocks - Wrap all tests in common describe to allow common setup/teardown - Use fs-extra for setup/teardown
This commit is separated from the previous cleanup to make the diff more readable.
This commit is separated from the previous cleanup to make the diff more readable.
brodybits
approved these changes
Aug 14, 2018
|
Thanks for the quick approval @brodybits 👍 Now there's some unrelated tests failing again. This really starts to piss me off... 😒 I can reproduce this one on master, locally. Bad. |
I spotted that too, looks like something flakey. Definitely not the first time. |
|
A quick bisect says it was me in 60ba439. Will take a look. |
Wonder if we should start to get rid of Q while you are at it? |
I have a local branch for that and it's definitely not something to do while we're at something else. There are various blockers. |
|
Merged as CI failures were unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the
pkgJson-restore.specpart of #629 as requested by @brodybits. See #629 for a full description.