Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make coverage script consider e2e tests too #637

Merged
merged 1 commit into from Aug 14, 2018
Merged

Make coverage script consider e2e tests too #637

merged 1 commit into from Aug 14, 2018

Conversation

raphinesse
Copy link
Contributor

Uses nyc for code coverage

@raphinesse raphinesse merged commit 6ccda67 into apache:master Aug 14, 2018
@raphinesse raphinesse deleted the better-cover branch August 14, 2018 22:27
brodybits pushed a commit to brodybits/cordova-lib that referenced this pull request Jun 11, 2019
remove coverage from .gitignore
fa8f3ea 
no longer needed since istanbul was replaced by nyc

NOTE: This should have been done in PR apache#637 (6ccda67) where istanbul
was replaced by nyc.
@brodybits brodybits mentioned this pull request Jun 11, 2019
Closed
1 task
@brodybits
Copy link
Contributor

coverage should have been removed from .gitignore, as I just proposed in PR #784

@brodybits brodybits mentioned this pull request Jun 11, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodybits brodybits brodybits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphinesse @brodybits