Create test projects instead of asserting their properties #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
changed the title
dpogue
approved these changes
Aug 15, 2018
raphinesse
force-pushed
the
create-not-assert
branch
from
e83efbb
to
ab1121a
Compare
|
Minor formatting changes and added TODO referencing apache/cordova-common#38 and apache/cordova-common#39. |
|
Merged because CI failure was unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the test fixtures in
pkgJson-restore.specare created from a base fixture in the tests that need them.Apart from better flexibility to change (will need this for performance tuning later) and less fixture files, this approach has the benefit that the test environment is defined in the tests themselves, making them easier to understand.