Cleanup platform.check #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
cleanup-platform.check
branch
from
bee153d
to
31920dd
Compare
raphinesse
force-pushed
the
cleanup-platform.check
branch
from
31920dd
to
9549bff
Compare
Codecov Report
@@ Coverage Diff @@
## master #650 +/- ##
==========================================
- Coverage 80.79% 80.74% -0.06%
==========================================
Files 57 57
Lines 3015 2996 -19
==========================================
- Hits 2436 2419 -17
+ Misses 579 577 -2
Continue to review full report at Codecov.
|
This should not change anything regarding functionality just make the code a _little_ more approachable and less horrible. This was originally created during an effort to remove Q API usage.
raphinesse
force-pushed
the
cleanup-platform.check
branch
from
9549bff
to
22e01b7
Compare
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ☠️ Closed/Abandoned
Sep 5, 2018
Apache Cordova: Tooling Pull Requests
automation
moved this from ☠️ Closed/Abandoned
to 🐣 New PR / Untriaged
Sep 5, 2018
janpio
moved this from 🐣 New PR / Untriaged
to ⛔ Blocked: Tests failing
in Apache Cordova: Tooling Pull Requests
raphinesse
moved this from ⛔ Blocked: Tests failing
to ⏳ Waiting for Review
in Apache Cordova: Tooling Pull Requests
Apache Cordova: Tooling Pull Requests
automation
moved this from ⏳ Waiting for Review
to 🏆 Merged, waiting for Release
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change anything regarding functionality just make the
code a little more approachable and less horrible.
This was originally created during an effort to remove Q API usage.