Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform.spec cleanup #679

Merged
merged 20 commits into from
Sep 7, 2018
Merged

platform.spec cleanup #679

merged 20 commits into from
Sep 7, 2018

Conversation

raphinesse
Copy link
Contributor

Another episode in the series Spec Cleanup.

Highlights

  • Re-enable some tests
  • Remove some tests for being duplicates after recent refactors
  • Slightly reduced overall runtime
  • Uniform, increased timeouts to address CI-3 of Flaky tests #642

@raphinesse
Promise chain formatting
aa19b84
@raphinesse
Use arrow functions
e6ef15e
@raphinesse
Use const and let
85f20e3
@raphinesse
Organize imports
d188d60
@raphinesse
Destructure test helpers for easier access
d98623c
@raphinesse
Factor out common setup & teardown
0f271cd
@raphinesse
Simpler checking of installed platforms
1f1d256
@raphinesse
Increase test timeouts to 2min for all tests
10f98bc 
Hopefully will make timeouts like CI-3 in apache#642 less likely
@raphinesse
Re-enable platform.spec tests 001-003
a8d44f7
@raphinesse
Make use of existing path variables
fb7f9a1
@raphinesse
Re-enable more stuff
1142d3a
@raphinesse
Factor out project creation
5ea614f
@raphinesse
Silence noisy output caused by cordova-browser
bd6217e
@raphinesse
Re-enable testing platform update
71ebb78
@raphinesse
Fix commented-out test parts in 008
31df80b
@raphinesse
Remove 006 since it's a subset of 008 since removing --fetch
949eed3
@raphinesse
Get rid of all the extra describe blocks
5646a2f
@raphinesse
Use fixture project instead of calling cordova create
d438c6c
@raphinesse
Merge tests 002 and 003 as they were doing the same thing
586c00a
@raphinesse
Do not install two platforms in plugin-focused test 008
8d29155
@raphinesse raphinesse mentioned this pull request Sep 6, 2018
Closed
7 tasks
@janpio janpio added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Sep 6, 2018
@janpio janpio moved this from 🐣 New PR / Untriaged to ⏳ Waiting for Review in Apache Cordova: Tooling Pull Requests Sep 6, 2018
Apache Cordova: Tooling Pull Requests automation moved this from ⏳ Waiting for Review to ✅ Approved, waiting for Merge Sep 7, 2018
@raphinesse raphinesse merged commit 9f95028 into apache:master Sep 7, 2018
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Sep 7, 2018
@raphinesse raphinesse deleted the platform.spec-cleanup branch September 7, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
bug enhancement
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphinesse @dpogue