Test, fix and cleanup cordova serve
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
via automation
The template is virtually identical with the previously generated one. There's minimal style changes and a few HTML fixes.
raphinesse
force-pushed
the
to-serve-and-protect
branch
from
2edab68
to
36ce5a5
Compare
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 83.03% 85.52% +2.48%
==========================================
Files 50 50
Lines 2759 2728 -31
==========================================
+ Hits 2291 2333 +42
+ Misses 468 395 -73
Continue to review full report at Codecov.
|
raphinesse
moved this from 🐣 New PR / Untriaged
to ⏳ Waiting for Review
in Apache Cordova: Tooling Pull Requests
12 tasks
|
I will go ahead and merge this in the coming days if there will be no further feedback. |
Apache Cordova: Tooling Pull Requests
automation
moved this from ⏳ Ready for Review
to 🏆 Merged, waiting for Release
Sep 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last larger refactor that I needed/wanted to get done before tackling #681 and in turn #657.
I tried to keep the commits very focused to make the review easier. I also did manual testing of the server.