Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron Platform #744

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Add Electron Platform #744

merged 2 commits into from
Dec 11, 2018

Conversation

erisu
Copy link
Member

@erisu erisu commented Dec 5, 2018

Platforms affected

none

What does this PR do?

  • Add Electron platform config and plugman default engine.
  • Updated platform test spec to include Electron

What testing has been done on this change?

  • npm t

@erisu erisu requested review from janpio and dpogue December 5, 2018 07:29
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Dec 5, 2018
@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #744 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files          50       50           
  Lines        2690     2690           
=======================================
  Hits         2311     2311           
  Misses        379      379
Impacted Files Coverage Δ
src/plugman/util/default-engines.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 217b1af...13b9fa1. Read the comment docs.

Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Dec 5, 2018
@erisu erisu merged commit a478ce3 into apache:master Dec 11, 2018
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Dec 11, 2018
@erisu erisu deleted the electron-platform-config branch April 4, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants