Remove handling of legacy .fetch.json files #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files in question have last been used in Cordova 4.3.0 and have been removed by commit c49eaa8.
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Mar 12, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR removes stale legacy handling code for files last created by Cordova 4.3.0.
The current version of the code transformed the old files to the new format and location, so removal of the current code should not affect any reasonably recent projects.
Since this is technically a breaking change, I thought it would be nice to include this into the upcoming major release.
I came across this when reviewing #680.
Description
I removed code that read
plugins/<PLUGIN>/.fetch.jsonand integrated it intoplugins/fetch.json.Testing
I ran the existing test suite.
Checklist
(platform)if this change only applies to one platform (e.g.(android))