Various test improvements #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 50 50
Lines 2598 2598
=======================================
Hits 2227 2227
Misses 371 371Continue to review full report at Codecov.
|
This sets executable bit for plugin hooks launched by superspawn, so that they actually run.
There is no need to clear all the test doubles in afterEach if we re-set them in beforeEach anyway.
isCordova does not actually care about the user's home directory.
raphinesse
force-pushed
the
misc-test-improvements
branch
from
9dd1650
to
8271fae
Compare
dpogue
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There's always things to improve with our tests.
Description
See commits.
Testing
Yes