refactor: use execa's cross-platform shebang support in HooksRunner #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
raphinesse
force-pushed
the
make-use-of-execa
branch
2 times, most recently
from
7783961
to
55f6907
Compare
Up until now, we have maintained code for shebang support in hook scripts on Windows. Fortunately, execa comes with support for that out of the box. So this commit drops our implmentation and makes use of execa's.
raphinesse
force-pushed
the
make-use-of-execa
branch
from
55f6907
to
750dfd5
Compare
erisu
approved these changes
Nov 11, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Nov 11, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, we have maintained code for shebang support in hook
scripts on Windows. Fortunately, execa comes with support for that out
of the box. So this commit drops our implementation and makes use of
execa's.