Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add package-lock.json #841

Merged
merged 1 commit into from Jun 29, 2020
Merged

chore: add package-lock.json #841

merged 1 commit into from Jun 29, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 29, 2020

Motivation, Context & Description

  • Add package-lock.json

@erisu erisu added this to the 10.0.0 milestone Jun 29, 2020
@erisu erisu requested a review from NiklasMerz June 29, 2020 06:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020 •
edited

Codecov Report

Merging #841 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files          46       46           
  Lines        2097     2097           
=======================================
  Hits         1878     1878           
  Misses        219      219

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7adf333...9343d12. Read the comment docs.

timbru31
timbru31 reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this PR does a bit more than just adding the lock files - can you split the lockfile and CI refactorings in two PRs?

@erisu erisu mentioned this pull request Jun 29, 2020
Closed
@erisu erisu requested a review from timbru31 June 29, 2020 12:59
timbru31
timbru31 approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erisu erisu merged commit 38e3e74 into apache:master Jun 29, 2020
@erisu erisu deleted the chore/add-package-lock branch June 29, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 approved these changes

@NiklasMerz NiklasMerz Awaiting requested review from NiklasMerz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erisu @codecov-commenter @timbru31