Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(osx): deprecate platform #851

Merged
merged 1 commit into from
Aug 8, 2022
Merged

feat(osx): deprecate platform #851

merged 1 commit into from
Aug 8, 2022

Conversation

brodybits
Copy link
Contributor

@brodybits brodybits commented Sep 3, 2020

Status

  • pending formal vote

Platforms affected

"osx" (macOS)

Motivation and Context

see this discussion in dev@cordova.apache.org

Description

set "deprecated": true for "osx" in src/platforms/platformsConfig.json

Testing

updated:

In a local checkout of cordova-cli:

npm i github:apache/cordova-lib#brodybits-deprecate-osx
./bin/cordova create test2
cd test2

Output of ../bin/cordova platform ls with no deprecated platforms:

Warning: using prerelease version 10.0.1-dev (cordova-lib@10.0.1-dev)
Installed platforms:
  
Available platforms: 
  android ^9.0.0
  browser ^6.0.0
  electron ^1.0.0
  ios ^6.1.0
  osx ^6.0.0 (deprecated)

Output of ../bin/cordova platform ls with "osx" platform added:

Warning: using prerelease version 10.0.1-dev (cordova-lib@10.0.1-dev)
Installed platforms:
  osx 6.0.0 (deprecated)
Available platforms: 
  android ^9.0.0
  browser ^6.0.0
  electron ^1.0.0
  ios ^6.1.0

Checklist

  • I've run the tests to see all new and existing tests pass - Travis CI ✅
  • I added automated test coverage as appropriate for this change
  • Commit Title is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • I've updated the documentation if necessary

@brodybits brodybits mentioned this pull request Sep 4, 2020
2 tasks
@brodybits brodybits marked this pull request as ready for review September 4, 2020 02:18
@brodybits brodybits marked this pull request as draft September 4, 2020 13:53
@erisu erisu changed the title (osx): deprecate "osx" (macOS) platform feat(osx): deprecate platform Aug 2, 2022
@erisu
Copy link
Member

erisu commented Aug 2, 2022

I have rebased this PR.

@erisu erisu marked this pull request as ready for review August 2, 2022 14:12
@erisu
Copy link
Member

erisu commented Aug 2, 2022

Cordova-OSX deprecation notice was already posted to the repo and the Cordova website reflects it.

apache/cordova-osx#118

@erisu erisu added this to the 11.1.0 milestone Aug 2, 2022
@erisu
Copy link
Member

erisu commented Aug 2, 2022

@brodybits thank you for the PR

@codecov-commenter
Copy link

Codecov Report

Merging #851 (86c6044) into master (42b4569) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #851   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          46       46           
  Lines        2123     2123           
=======================================
  Hits         1874     1874           
  Misses        249      249           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@erisu erisu merged commit 30a58fd into master Aug 8, 2022
@erisu erisu deleted the brodybits-deprecate-osx branch August 8, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants