Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(dev)!: bump @cordova/eslint-config@^4.0.0 w/ fix #888

Merged
merged 8 commits into from Nov 2, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 2, 2021

Motivation, Context & Description

  • Use latest Cordova eslint config.
  • Applied Fix

Requires #887

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 11.0.0 milestone Nov 2, 2021
@erisu erisu requested a review from raphinesse November 2, 2021 09:25
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #888 (4bddba2) into master (f33540d) will not change coverage.
The diff coverage is 93.86%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          46       46           
  Lines        2123     2123           
=======================================
  Hits         1874     1874           
  Misses        249      249           
Impacted Files Coverage Δ
src/cordova/serve.js 100.00% <ø> (ø)
src/plugman/init-defaults.js 0.00% <0.00%> (ø)
src/cordova/targets.js 19.23% <33.33%> (ø)
src/plugman/createpackagejson.js 50.00% <40.00%> (ø)
src/plugman/platform.js 20.00% <40.00%> (ø)
src/cordova/clean.js 40.00% <71.42%> (ø)
src/plugman/create.js 91.42% <92.85%> (ø)
src/plugman/install.js 90.87% <95.45%> (ø)
src/plugman/fetch.js 90.83% <96.66%> (ø)
src/plugman/uninstall.js 93.46% <98.21%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33540d...4bddba2. Read the comment docs.

Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. LGTM otherwise

spec/cordova/plugin/remove.spec.js Outdated Show resolved Hide resolved
spec/plugman/util/metadata.spec.js Outdated Show resolved Hide resolved
@erisu erisu requested a review from raphinesse November 2, 2021 11:19
@erisu erisu merged commit a4c6d5c into apache:master Nov 2, 2021
@erisu erisu deleted the dep/bump-eslint branch November 2, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants