Need to check for object existence #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this code runs and a folder called "Resources" is not in the XCode project this call fails. Need to check for object existence before accessing path. There should be no impact from this change only preventing a run time error when a folder is not present
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 89.97% 89.97%
=======================================
Files 6 6
Lines 2374 2374
=======================================
Hits 2136 2136
Misses 238 238
Continue to review full report at Codecov.
|
nikhname
approved these changes
Jun 10, 2020
timbru31
approved these changes
Jun 10, 2020
NiklasMerz
approved these changes
Jun 12, 2020
DamienBitrise
added a commit
to DamienBitrise/bitrise-test-plan-sharder
that referenced
this pull request
Jun 12, 2020
Use cordova-node-xcode while waiting for the next release with this bug fix in it apache/cordova-node-xcode#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this code runs and a folder called "Resources" is not in the XCode project this call fails.
Need to check for object existence before accessing path.
There should be no impact from this change only preventing a run time error when a folder is not present