Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Test Framework Implementation Improvements #67

Merged
merged 2 commits into from Oct 2, 2018

Conversation

erisu
Copy link
Member

@erisu erisu commented Sep 15, 2018

Platforms affected

none

What does this PR do?

  • Add Code Coverage
  • Refactor Test Specs. Uses const, arrow functions, etc.
  • Updated .gitignore

What testing has been done on this change?

  • npm test

- Restructure Test Files
- Added NYC Test Coverage
- Udpated .gitignore to Exclude Test Coverage and Vscode
@erisu erisu changed the title OSX Testing Framework Implementation Improvement Test Framework Implementation Improvements Sep 15, 2018
@janpio janpio added this to 🐣 New PR / Untriaged in Apache Cordova: Platform Pull Requests Sep 16, 2018
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"test": "npm run eslint && npm run test:coverage",
"test:objc": "jasmine --config=tests/spec/objc.json",
"test:component": "jasmine --config=tests/spec/component.json",
"test:coverage": "nyc jasmine --config=tests/spec/coverage.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming the file all.json would have been more obvious to me. But that's only nitpicking.

Apache Cordova: Platform Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Sep 18, 2018
@erisu erisu merged commit dcdea9a into apache:master Oct 2, 2018
Apache Cordova: Platform Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Oct 2, 2018
@erisu erisu deleted the test-framework-improvement branch April 4, 2019 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Apache Cordova: Platform Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants