CB-12813 ios Fix target chooser to use full target name #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
reviewed
Nov 16, 2017
|
Fixed a merge conflict. Change itself looks good and solves the problem of the JIRA issue, but I am not sure if this could have negative effects on how we currently use paramedic. |
|
Issue link was https://issues.apache.org/jira/projects/CB/issues/CB-12813 |
|
@erisu Is this already implemented this way now after your last changes? |
|
@janpio yes current master is already implemented with these changes. I will close this PR. tsubik, thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
Fixes target Chooser to use full target name with OS version instead of only device name.
What testing has been done on this change?
I'm using cordova-paramedic for testing my own plugin. Integration testing with choosing the right target.
Checklist