Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.2.0 on npm? #619

Closed
grischan opened this issue Jul 6, 2020 · 7 comments
Closed

Release 4.2.0 on npm? #619

grischan opened this issue Jul 6, 2020 · 7 comments

Comments

@grischan
Copy link

grischan commented Jul 6, 2020

Hello,

could the new version 4.2.0 published on npmjs? The latest version there is 4.1.0.

Thank you and best Regards
Christian

@erisu
Copy link
Member

erisu commented Jul 6, 2020

Cordova does not have a 4.2.0 release.

@erisu erisu closed this as completed Jul 6, 2020
@grischan
Copy link
Author

grischan commented Jul 6, 2020

I dont mean the version of cordova, I mean the camera-plugin itself on npm.

@timbru31
Copy link
Member

timbru31 commented Jul 6, 2020

That's what erisu meant, too. The attempted release for 4.2.0 failed as it's broken on Android. We are currently working on a new version (no ETA)

@DURK
Copy link

DURK commented Aug 19, 2020

@timbru31 I don't see any issues on the Travis build of 4.2.0. Am I missing something?
https://travis-ci.org/github/apache/cordova-plugin-camera/builds/684163700

@timbru31
Copy link
Member

Yes the issue was not discovered with automated testing (i.e., Travis is green)but observed when we've done manual testing.

Yes, a regression test should be added, but our current plugin testing setup is...well not optimal.

@DURK
Copy link

DURK commented Aug 20, 2020

@timbru31 I see. Do you know what issue was found on Android?

Reason I'm asking: I'm mainly using the Capacitor's Camera API, but as this doesn't have the select a video from library feature, I'm still using the cordova-plugin-camera for that. So far, I've not found any issues with this feature, so I could be safe just updating to 4.2.0. But I want to be sure it's not some obscure issue or memory leak.

@breautek
Copy link
Contributor

The email thread can be found at https://lists.apache.org/thread.html/rd4e20db0cc4e038f3ea9c14d29648fded38f7605359253c976a2e38d%40%3Cdev.cordova.apache.org%3E

This PR I guess is the culprit, #588 but I'm not sure in what way it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants