Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Cache images in device storage, devices have enough space now. #588

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

purplecabbage
Copy link
Contributor

Platforms affected

Android

Motivation and Context

We used to have to cache images on removable storage because devices did not have enough space, this is not an issue any longer, and it is better to let the system handle cache cleanup.

Description

Remove conditional, and just default to application storage

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@purplecabbage purplecabbage changed the title Cache images in device storage, devices have enough space now. [Android] Cache images in device storage, devices have enough space now. Apr 28, 2020
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purplecabbage purplecabbage merged commit e9aba07 into apache:master Apr 30, 2020
@purplecabbage purplecabbage deleted the AndroidCacheLocal branch April 30, 2020 17:46
@breautek breautek mentioned this pull request Aug 21, 2020
@JacobIsrael18
Copy link

Google's camera app and MANY others are still crashing or freezing.
Screenshot_20210117-000351_Camera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants