Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate queries element in AppManifest.xml #779

Closed
Abrissirba opened this issue Nov 19, 2021 · 0 comments · Fixed by #780
Closed

Duplicate queries element in AppManifest.xml #779

Abrissirba opened this issue Nov 19, 2021 · 0 comments · Fixed by #780

Comments

@Abrissirba
Copy link
Contributor

Bug Report

Problem

Android SDK 30 requires you to define which other apps you app want to communicate with. This can be done by adding the following to config.xml

<config-file parent="queries" target="AndroidManifest.xml">
    <package android:name="<name of package>" />
</config-file>

What is expected to happen?

When I run add platform I expect to get one queries element in AppManifest.xml

What does actually happen?

I get two elements. One is the one I added myself in config.xml and the other is comming from plugin.xml in cordova-plugin-camera.

Information

Introduced here: abfbbd3.

I have tried to manually edit the plugin.xml file locally to this and confirmed that it works

<config-file target="AndroidManifest.xml" parent="queries">
                <intent>
                    <action android:name="android.media.action.IMAGE_CAPTURE" />
                </intent>
                <intent>
                    <action android:name="android.intent.action.GET_CONTENT" />
                </intent>
                <intent>
                    <action android:name="android.intent.action.PICK" />
                </intent>
                <intent>
                    <action android:name="com.android.camera.action.CROP" />
                    <data android:scheme="content" android:mimeType="image/*"/>
                </intent>
        </config-file>

Command or Code

cordova platform add android

Environment, Platform, Device

Version information

cordova-plugin-camera@6.0.0
"cordova-android": "^10.1.1",
10.0.0 (cordova-lib@10.1.0)

Checklist

  • [x ] I searched for existing GitHub issues
  • [ x] I updated all Cordova tooling to most recent version
  • [ x] I included all the necessary information above
Abrissirba added a commit to Abrissirba/cordova-plugin-camera that referenced this issue Nov 19, 2021
Solves the issue with duplicate queries elements in AppManifest.xml

apache#779
erisu pushed a commit that referenced this issue Mar 18, 2022
Solves the issue with duplicate queries elements in AppManifest.xml

#779
davidofwatkins added a commit to zenput/cordova-plugin-camera that referenced this issue Oct 20, 2023
* fix(android): update queries in plugin.xml (apache#780)

Solves the issue with duplicate queries elements in AppManifest.xml

apache#779

* fix(ios): preserving EXIF data (apache#712)

* ci(android): update java requirement for cordova-android@11 (apache#798)

* dep(npm): bump package-lock v2 w/ rebuild (apache#800)

* docs(README): Document ANDROIDX_CORE_VERSION variable (apache#808)

* fix(browser): use navigator.mediaDevices.getUserMedia (apache#810)

* ci: sync workflow with paramedic (apache#804)

* fix(android): set applicationId (apache#827)

Co-authored-by: Alexandre Alves <aalves@seamlink.com>

* chore(android): Cleanup obsolete BuildConfig comments (apache#831)

* ci(android): Drop API 22 & 31. Added API 24 & 33 (apache#835)

Co-authored-by: エリス <erisu@users.noreply.github.com>

* chore: bump plugin version 7.0.0-dev (apache#845)

* dep(dev)!: bump @cordova/eslint-config@5.0.0 (apache#846)

* dep(dev)!: bump @cordova/eslint-config@5.0.0
* chore: apply automatic lint fix

* feat(android)!: Android 13 support (apache#844)

* feat(android)!: Android 13 support
* refactor(android): simplify getPermissions logic
* feat(android)!: bump cordova-android requirement to >=12.0.0
* feat(android): update saveAlbumPermission to include Android 9 and below use case

---------

Co-authored-by: ochakov <evgeny@ochakov.com>

* chore: Update SUPPORT_QUESTION.md template (apache#849)

* fix!: remove deprecated platforms (apache#848)

* chore: remove windows/osx from plugin.xml (apache#850)

* ci(gh-action): sync with paramedic configs (apache#851)

* release(camera-v7.0.0): updated version and RELEASENOTES.md

* chore: bump version 7.0.1-dev

---------

Co-authored-by: Marcus Abrahamsson <marcus.abrahamsson13@gmail.com>
Co-authored-by: Scott Murphy <scott@alwaysvip.com>
Co-authored-by: エリス <erisu@users.noreply.github.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: seamlink-aalves <49952868+seamlink-aalves@users.noreply.github.com>
Co-authored-by: Alexandre Alves <aalves@seamlink.com>
Co-authored-by: Norman Breau <norman@nbsolutions.ca>
Co-authored-by: ochakov <evgeny@ochakov.com>
Co-authored-by: Erisu <erisu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant