feat(browser): Give video and button tags an id attribute #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclaim
changed the title
|
Does this have a corresponding JIRA issue? Also, I don't see your name in the ICLA list; could you please submit an ICLA? |
|
@Clementp57 any updates? |
janpio
moved this from ⏳ Waiting for Review
to 🐣 New PR / Untriaged
in Apache Cordova: Plugin Pull Requests
|
Hey @Clementp57 , there seems to be a merge conflict now. Could you maybe fix this? Thanks. |
janpio
moved this from 🐣 New PR / Untriaged
to 💥 Blocked: Conflict
in Apache Cordova: Plugin Pull Requests
janpio
changed the title
janpio
requested changes
Jul 3, 2019
Apache Cordova: Plugin Pull Requests
automation
moved this from 💥 Blocked: Conflict
to 🙅 Pending Approval
Jul 3, 2019
|
closing since the conflicts have not been fixed after a year |
Apache Cordova: Plugin Pull Requests
automation
moved this from 🙅 Reviewed, but not approved
to ☠️ Closed/Abandoned
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developer to style both video and button tags in Browser.