Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sample section to the Camera plugin README #203

Closed
wants to merge 3 commits into from
Closed

Added Sample section to the Camera plugin README #203

wants to merge 3 commits into from

Conversation

Mikejo5000
Copy link

No description provided.

function setOptions(srcType) {
var options = {
quality: 20,
destinationType: Camera.DestinationType.FILE_URI,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to clarify that window.resolveLocalFileSystemURL requires that you add the file plugin

@riknoll
Copy link
Contributor

riknoll commented Apr 12, 2016

I made a few comments inline, but nothing major.

Also, README.md is actually a generated file in this repo (and this repo only). It would be great if you could move the changes you made in that file over to jsdoc2md/TEMPLATE.md. README.md should get automatically regenerated with your changes after you make a commit. You can edit README.md directly in the other repos (the camera plugin is just special)


If you want to do something like copy the image to another location, or upload it somewhere using the FileTransfer plugin, you need to get a FileEntry object for the returned picture. To do that, call `window.resolveLocalFileSystemURL` on the file URI returned by the Camera app. If you need to use a FileEntry object, set the `destinationType` to `Camera.DestinationType.FILE_URI` in your CameraOptions object (this is also the default value).

>*Note* You need the File plugin to call `window.resolveLocalFileSystemURL`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to the file plugin here?

@riknoll
Copy link
Contributor

riknoll commented Apr 14, 2016

LGTM! I'll merge this later today and regenerate the README

@asfgit asfgit closed this in 6d058fe Apr 15, 2016
swbradshaw pushed a commit to swbradshaw/cordova-plugin-camera that referenced this pull request Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants