CB-12458 - [cordova-plugin-camera] - The information about old versio… #253
Conversation
…ns of the plugin install the deprecated ID CB-12458 - [cordova-plugin-camera] - The information about old versions of the plugin install the deprecated ID Changed in the text to make it clear. Referent the JIRA: https://issues.apache.org/jira/browse/CB-12458
…ordova cli install the deprecated ID to make it clear "This means that if you use a Cordova CLI version < 5 you can still install plugins using the old deprecated id as it's translated by the CLI to the new one but that doesn't happen on Cordova CLI 5+, I don't see how your addition makes it more clear."
Supplement it with information about old versions of plugins Ref: CB-12458 -[cordova-plugin-camera] - The information about old versions of the plugin install the deprecated ID is missing in the README
Supplement it with information about old versions of plugins Ref: CB-12458 -[cordova-plugin-camera] - The information about old versions of the plugin install the deprecated ID is missing in the README
|
@stevengill Could you check it for we finilise this small PR? |
|
@camilamacedo86 I just explained to you how the deprecated ID works so you could understand, but I don't think we need to document it considering version 1 is two years old and nobody should be using older versions with the deprecated id by now. I think you can close the PR and the issue. |
|
I lot of people has applications in old versions because the apps are stable in the market and I think this is an important information. However, oks I am closing here the JIRA and the PR. |
|
A version with the deprecated id of the camera plugin will crash on new installs on iOS 10 devices, so everybody using camera plugin should be using at least 2.3.1, also 2.2.0 is needed to handle Android 6 permissions. This PR explains what happens when you install the plugin using the new id but using an old version of the plugin that used the deprecated id, that shouldn't happen nowadays. A legacy project that already have the plugin installed, it was installed with the old id, so it doesn't need the explanation neither. Anyway, thanks for the PR! I would like to see you contributing in other issues in the future. |
…ns of the plugin install the deprecated ID
CB-12458 - [cordova-plugin-camera] - The information about old versions of the plugin install the deprecated ID
Changed in the text to make it clear. Referent the JIRA: https://issues.apache.org/jira/browse/CB-12458
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist