Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13384: (browser) Added deprecation of video.src compatibility #288

Merged
merged 2 commits into from
May 25, 2018
Merged

CB-13384: (browser) Added deprecation of video.src compatibility #288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83283a
CB-13384: (browser) Added deprecation of video.src compatibility
mvandervliet Oct 3, 2017
cee7ca8
CB-13384: Updated to reflect property detection rather than deprecati…
mvandervliet May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/browser/CameraProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ function capture (success, errorCallback, opts) {

var successCallback = function (stream) {
localMediaStream = stream;
video.src = window.URL.createObjectURL(localMediaStream);
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do property detection instead of a try/catch.

if ('srcObject' in video) {
   // 
} else {
   //
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks @shazron

video.src = window.URL.createObjectURL(localMediaStream);
} catch (e) {
video.srcObject = localMediaStream;
}
video.play();

document.body.appendChild(parent);
Expand Down