Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: bump project requirements #628

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 14, 2020

Motivation and Context

Bump the project requirements.

  • Cordova Android >= 9.0.0
  • Cordova CLI >= 9.0.0

Note: Changes also include #627. This PR should be rebased after #627 is merged in.

@erisu
Copy link
Member Author

erisu commented Jul 14, 2020

@jcesarmobile Any thoughts on iOS requirements being set to 6.x?

I don't know if there are any breaking changes on the iOS side of this plugin, but from the current testing system standpoint (paramedic) I believe it always checks out the latest Cordova iOS (6.x) which requires Xcode 11 to be used. This means we might be only testing Xcode 11+... At least the additional tests do not pass on any version below Xcode 11.

@erisu erisu changed the title Breaking/requirement bump breaking: bump project requirements Jul 14, 2020
@erisu erisu force-pushed the breaking/requirement-bump branch 2 times, most recently from fff6af5 to 1af2d92 Compare July 14, 2020 09:19
@erisu erisu added this to the 5.0.0 milestone Jul 14, 2020
@jcesarmobile
Copy link
Member

I think we should require cordova-ios 5.1.0, I see no reason to require 6.0.0 in this plugin.

Not being able to test on Xcode 10 is not a big problem, considering Apple requires Xcode 11 to submit apps.

I've created a thread on the mail list to talk about the engines and used this PR as an example of what I think we should be doing.

@erisu erisu force-pushed the breaking/requirement-bump branch 3 times, most recently from 7f29327 to 6ae51a2 Compare July 28, 2020 01:56
@erisu
Copy link
Member Author

erisu commented Jul 28, 2020

@jcesarmobile I set it to cordova-ios >= 5.1.0 as you mentioned in previous comment but also debated if it should really be >= 5.1.1. 5.1.0 had a bug with the new WKWebViewOnly flag being set and prepare running before the platform actually existing. Or something like this if memory is correct. But 5.1.1 fix that prepare issue surrounding the flag.

Other than that, this PR I think is OK.

@jcesarmobile
Copy link
Member

I guess if people face the prepare bug will update from 5.1.0 to 5.1.1, but you can set it to 5.1.1 if you prefer

@erisu erisu force-pushed the breaking/requirement-bump branch from 6ae51a2 to efb4d3b Compare July 28, 2020 11:02
@erisu erisu merged commit 4549621 into apache:master Jul 28, 2020
@erisu erisu deleted the breaking/requirement-bump branch July 28, 2020 11:25
IT-MikeS pushed a commit to OutSystems/cordova-plugin-camera that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants