Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove NATIVE_URI DestinationType #637

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

jcesarmobile
Copy link
Member

Platforms affected

all

Motivation and Context

NATIVE_URI was only used on iOS and windows, on Android it acts like FILE_URI.

On iOS it returned ALAssetsLibrary urls that are not compatible with WKWebView and ALAssetsLibrary was deprecated on iOS 9, so I don't think it makes sense to keep this destination type since it's not supported by all platforms and it's deprecated on iOS.

Description

also removes other usages of ALAssetsLibrary since it's deprecated

Testing

tested on real iOS device

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@jcesarmobile jcesarmobile requested review from erisu, breautek and timbru31 and removed request for erisu and breautek July 24, 2020 17:33
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks OK to me.

@jcesarmobile jcesarmobile merged commit 0333d00 into apache:master Aug 7, 2020
@jcesarmobile jcesarmobile deleted the remove-native-uri branch August 7, 2020 12:38
@FBNitro
Copy link

FBNitro commented Sep 2, 2020

This is used on Windows also I thought, because if I pick a file from the photo storage, I can only seem to get a hold of the correct path using the NATIVE_URI.

I'm currently on 4.1.0.

@Gillardo
Copy link
Contributor

when this is removed, how do i get the PATH to the file from the PHOTOLIBRARY, as the FILE_URI returns the file that is in temporary storage, i want the file that is saved like NATIVE_URI did before

IT-MikeS pushed a commit to OutSystems/cordova-plugin-camera that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants