Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release notify action #654

Merged
merged 3 commits into from
Aug 11, 2021
Merged

chore: add release notify action #654

merged 3 commits into from
Aug 11, 2021

Conversation

NiklasMerz
Copy link
Member

Platforms affected

Motivation and Context

We want to test a new action that closes issues that are just asking for a new release and reduce noise. Let's start with this plugin.

Description

This PR adds a new Github action built by me to add a comment and closes the issue if it looks like the issue is just created to ask for a release.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@NiklasMerz
Copy link
Member Author

Some discussion here: NiklasMerz/release-notify#4

steps:
- uses: niklasmerz/release-notify@master
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need infra to add the secret?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if INFRA can disable the secret. It's a standard Github secret that I never added to my repo:
grafik

Copy link
Member Author

@NiklasMerz NiklasMerz Sep 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token

I did not find an option to disable it in my orgs. Not sure though. But you can disable third party actions for orgs, repos.

NiklasMerz and others added 2 commits September 3, 2020 17:53
Comments about releases should not close issues
@erisu
Copy link
Member

erisu commented Aug 11, 2021

👍

@erisu erisu merged commit 3112e5f into master Aug 11, 2021
@erisu erisu deleted the release-action branch August 11, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants