Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): return exception message (where it exists) #687

Merged
merged 4 commits into from
Aug 11, 2021
Merged

fix(android): return exception message (where it exists) #687

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33a4fab
fix(android): return exception message (where it exists) in error cal…
dpa99c Nov 9, 2020
fe2471b
fix: apply suggestion for getLocalizedMessage
erisu Aug 11, 2021
12a5998
fix: apply suggestion for getLocalizedMessage
erisu Aug 11, 2021
da3b0b3
fix: apply suggestion for getLocalizedMessage
erisu Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/android/CameraLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ else if (destType == FILE_URI) {

} catch (Exception e) {
e.printStackTrace();
this.failPicture("Error retrieving image.");
this.failPicture("Error retrieving image: "+e.getMessage());
erisu marked this conversation as resolved.
Show resolved Hide resolved
}
} else {
this.callbackContext.success(finalLocation);
Expand Down Expand Up @@ -829,7 +829,7 @@ else if (srcType == CAMERA) {
}
} catch (IOException e) {
e.printStackTrace();
this.failPicture("Error capturing image.");
this.failPicture("Error capturing image: "+e.getMessage());
erisu marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down Expand Up @@ -1268,7 +1268,7 @@ public void processPicture(Bitmap bitmap, int encodingType) {
code = null;
}
} catch (Exception e) {
this.failPicture("Error compressing image.");
this.failPicture("Error compressing image: "+e.getMessage());
erisu marked this conversation as resolved.
Show resolved Hide resolved
}
jpeg_data = null;
}
Expand Down