Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set the 5.x versions locked to cordova-android <10.0.0 #747

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 17, 2021

Platforms affected

Android

Motivation and Context

Cordova-Android 10 uses AndroidX... Therefore we should lock this plugin version 5.x to Cordova-Android 9.x

Description

Lock plugin 5.x to Cordova-Android 9.x

Testing

  • n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added the bug label Jul 17, 2021
@erisu erisu requested a review from jcesarmobile July 17, 2021 08:04
@erisu erisu merged commit 1e20a9b into apache:master Jul 28, 2021
@erisu erisu deleted the fix/lock-version branch July 28, 2021 05:30
@WuglyakBolgoink
Copy link

Hallo @erisu / @breautek

it means, that I can't use cordova-android@10+ with "cordova-plugin-androidx-adapter" too and must wait camera plugin v6 now?

@breautek
Copy link
Contributor

The adapter plugin is not necessary for this plugin anymore since the legacy android support libraries have been migrated to use androidx.

You can still use a version that doesn't have this pin with cordova-android@10 / cordova-plugin-androidx-adapter in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants