Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

(android) Fix issue crash on save and remove method #177

Conversation

igormartsekha
Copy link

Platforms affected

Android

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Oct 30, 2018

Can you please explain the changes you did and why those are required? Otherwise it will be hard to review your PR and merge it.

@igormartsekha
Copy link
Author

@janpio Hello
if someone wants to use remove and save method, them should receive WRITE and READ permissions to do it. Current version asks WRITE permission for save() and remove() method but doesn't ask READ permission. If you run save/remove without READ permission, a app will throw the exception and crashed.
So, my changes will fix this behaviour and save/remove methods will work in proper way.

@lechediaz
Copy link

lechediaz commented May 10, 2019

Hello, pleease install the android API level 27 that corresponds to Android 8.1(Oreo) before execute The Travis CI build.

@juanludukeboss
Copy link

Hi, I have Android 10 and API Level 27 and I have made the changes indicated in the commit: d6f42eb , but when I try to save the contact, the App Crash. The contact is saved perfectly, but the App Crash.
I have tested always in Android 9 and I have the same problem.

Any idea??. Please, I need a solution.

Thank so much.

@juanludukeboss
Copy link

Sorry, Finally it's working Perfectly. My problem was that I had not removed the android platform and added again.
Thanks so much, I'm very happy that my problem with the save contacts is solved.
👍 👍

@timbru31
Copy link
Member

timbru31 commented Jan 9, 2023

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.

@timbru31 timbru31 closed this Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants