Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: undeprecate plugin #54

Merged
merged 5 commits into from
Aug 25, 2020
Merged

docs: undeprecate plugin #54

merged 5 commits into from
Aug 25, 2020

Conversation

timbru31
Copy link
Member

Revert "Deprecate it"

This reverts commit b6f834e.

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31 timbru31 requested a review from erisu August 25, 2020 11:00
erisu
erisu reviewed Aug 25, 2020
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this sound?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@timbru31 timbru31 linked an issue Aug 25, 2020 that may be closed by this pull request
Should deprecation status be removed? #52
Closed
@timbru31 @erisu
Apply suggestions from code review
e1461d8 
Co-authored-by: エリス <erisu@users.noreply.github.com>
@timbru31 timbru31 requested a review from breautek August 25, 2020 11:15
@timbru31 timbru31 merged commit 4f4db46 into master Aug 25, 2020
@timbru31 timbru31 deleted the feat/undeprecate branch August 25, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

@breautek breautek Awaiting requested review from breautek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should deprecation status be removed?
2 participants
@timbru31 @erisu