Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(npm): improve ignore list #121

Merged
merged 1 commit into from
Mar 26, 2020
Merged

chore(npm): improve ignore list #121

merged 1 commit into from
Mar 26, 2020

Conversation

timbru31
Copy link
Member

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31
Copy link
Member Author

Testing can be done with npm pack --dry-run:

npm notice
npm notice 📦  cordova-plugin-device@2.0.4-dev
npm notice === Tarball Contents ===
npm notice 11.4kB LICENSE
npm notice 163B   NOTICE
npm notice 957B   src/ios/CDVDevice.h
npm notice 932B   src/osx/CDVDevice.h
npm notice 5.4kB  src/android/Device.java
npm notice 3.0kB  www/device.js
npm notice 2.8kB  src/browser/DeviceProxy.js
npm notice 4.4kB  src/windows/DeviceProxy.js
--> SEE HERE  npm notice 4.5kB  tests/tests.js
npm notice 1.3kB  package.json
--> SEE HERE  npm notice 260B   tests/package.json
npm notice 3.3kB  src/ios/CDVDevice.m
npm notice 3.8kB  src/osx/CDVDevice.m
npm notice 1.4kB  CONTRIBUTING.md
npm notice 7.3kB  README.md
npm notice 11.7kB RELEASENOTES.md
npm notice 1.4kB  types/index.d.ts
npm notice 3.2kB  plugin.xml
--> SEE HERE npm notice 1.2kB  tests/plugin.xml
npm notice === Tarball Details ===
npm notice name:          cordova-plugin-device
npm notice version:       2.0.4-dev
npm notice filename:      cordova-plugin-device-2.0.4-dev.tgz
npm notice package size:  18.0 kB
npm notice unpacked size: 68.4 kB
npm notice shasum:        230a362b1c11848e96b2434ca5f0f8326be099ea
npm notice integrity:     sha512-vb64LVNUOulYO[...]5zcqnltjI3ZCQ==
npm notice total files:   21
npm notice
cordova-plugin-device-2.0.4-dev.tgz

Obviously, we shouldn't ship the tests/ folder with npm.

@timbru31 timbru31 changed the title build: ignores tests folder for npm tarball chore(npm): improve ignore list Mar 26, 2020
@timbru31 timbru31 merged commit d85e146 into master Mar 26, 2020
@timbru31 timbru31 deleted the fix/ignore-tests-in-tar branch March 26, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants